fix: make shortcut change work for shortcuts with two words, added sidebar shortcut, fix categories order #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
dosubot
bot
added
size:L
lucaseduoli
changed the title
github-actions
bot
added
bug
mfortman11
approved these changes
Nov 25, 2024
anovazzi1
requested changes
Nov 25, 2024
ogabrielluiz
force-pushed
the
fix/sidebar_shortcut
branch
from
6cc1ac5 to
245c7f7
Compare
ogabrielluiz
force-pushed
the
fix/sidebar_shortcut
branch
from
245c7f7 to
b97578e
Compare
ogabrielluiz
force-pushed
the
fix/sidebar_shortcut
branch
from
b97578e to
3d56b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the shortcut management and sidebar functionality in the frontend application. The most important changes include the addition of a new keyboard shortcut for toggling the sidebar, modifications to the shortcut storage structure, and updates to the utility functions for handling shortcuts.
Shortcut Management Updates:
toggleSidebarkeyboard shortcut to the default shortcuts list and theuseShortcutsStorestate. (src/frontend/src/constants/constants.ts,src/frontend/src/stores/shortcuts.ts) [1] [2]useShortcutsStoreto use consistent naming for thefreezePathshortcut. (src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/hooks/use-shortcuts.tsx,src/frontend/src/stores/shortcuts.ts) [1] [2]handleRestorefunction inShortcutsPageto useshortcut_modinstead ofshortcutfor updating unique shortcuts. (src/frontend/src/pages/SettingsPage/pages/ShortcutsPage/index.tsx)Sidebar Functionality Enhancements:
useHotkeysanduseShortcutsStoreto handle the newtoggleSidebarshortcut, replacing the previous hardcoded keyboard shortcut. (src/frontend/src/components/ui/sidebar.tsx) [1] [2]SIDEBAR_KEYBOARD_SHORTCUTconstant and its associated event listener for toggling the sidebar. (src/frontend/src/components/ui/sidebar.tsx) [1] [2]Utility and Miscellaneous Changes:
toNormalCaseutility function and updated relevant imports and usage to ensure consistent shortcut naming. (src/frontend/src/pages/SettingsPage/pages/ShortcutsPage/EditShortcutButton/index.tsx,src/frontend/src/pages/SettingsPage/pages/ShortcutsPage/index.tsx) [1] [2]FlowSidebarComponentto correctly sort categories. (src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx)