Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve timeout handling in Document QA test #4798

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request refactors the Document QA test to improve timeout handling. It updates the code to use waitForSelector instead of waitForTimeout for better synchronization.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 23, 2024 17:12
@ogabrielluiz ogabrielluiz merged commit 94bdc8e into main Nov 23, 2024
18 checks passed
@ogabrielluiz ogabrielluiz deleted the improveDocumentQA branch November 23, 2024 17:24
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
)

refactor: Improve page loading and timeout handling in Document QA test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants