refactor: Remove unnecessary exception logging and improve error logging #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
github-actions
bot
added
refactor
ogabrielluiz
force-pushed
the
remove-unnecessary-exception-logs
branch
from
5ade389 to
e801401
Compare
CodSpeed Performance ReportMerging #4676 will improve performances by 35.45%Comparing Summary
Benchmarks breakdown
|
italojohnny
approved these changes
Nov 19, 2024
italojohnny
force-pushed
the
remove-unnecessary-exception-logs
branch
from
e801401 to
a2b6784
Compare
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…ing (langflow-ai#4676) * Remove unnecessary exception logging in API key decryption * Removes unnecessary exception logging in services * fix: Change debug logging to error logging for user last login update * fix: Enhance error logging to include exception details in various services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on cleaning up the logging within the codebase by removing unnecessary exception logging in API key decryption and various services. Additionally, it enhances the logging for user last login updates by changing debug logs to error logs, ensuring that critical issues are appropriately captured. This results in less confusion when expected errors occur.