Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unnecessary exception logging and improve error logging #4676

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Nov 18, 2024

This pull request focuses on cleaning up the logging within the codebase by removing unnecessary exception logging in API key decryption and various services. Additionally, it enhances the logging for user last login updates by changing debug logs to error logs, ensuring that critical issues are appropriately captured. This results in less confusion when expected errors occur.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 18, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 18, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 18, 2024
@ogabrielluiz ogabrielluiz force-pushed the remove-unnecessary-exception-logs branch from 5ade389 to e801401 Compare November 18, 2024 22:16
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4676 will improve performances by 35.45%

Comparing remove-unnecessary-exception-logs (a2b6784) with main (6133fed)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main remove-unnecessary-exception-logs Change
test_successful_run_with_input_type_any 297.7 ms 219.8 ms +35.45%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@italojohnny italojohnny force-pushed the remove-unnecessary-exception-logs branch from e801401 to a2b6784 Compare November 19, 2024 12:09
@italojohnny italojohnny enabled auto-merge (squash) November 19, 2024 12:09
@italojohnny italojohnny merged commit 7614cfb into main Nov 19, 2024
20 checks passed
@italojohnny italojohnny deleted the remove-unnecessary-exception-logs branch November 19, 2024 12:24
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…ing (langflow-ai#4676)

* Remove unnecessary exception logging in API key decryption

* Removes unnecessary exception logging in services

* fix: Change debug logging to error logging for user last login update

* fix: Enhance error logging to include exception details in various services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants