Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve freeze-path.spec.ts and freeze.spec.ts files #4618

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes refactoring changes to the freeze-path.spec.ts and freeze.spec.ts files. The changes involve improving the timing of certain actions by using waitForSelector instead of waitForTimeout. Additionally, unnecessary code has been removed from the freeze.spec.ts file. These changes aim to enhance the efficiency and readability of the code.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 14, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@anovazzi1 anovazzi1 merged commit 8ebe108 into main Nov 21, 2024
18 checks passed
@anovazzi1 anovazzi1 deleted the refactorFreezeTests branch November 21, 2024 19:46
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
…low-ai#4618)

* refactor: Improve time and use waitForSelector in freeze-path.spec.ts

* refactor: Improve time and use waitForSelector in freeze-path.spec.ts

* fromat code

* Refactor freeze.spec.ts: Remove unnecessary code
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…low-ai#4618)

* refactor: Improve time and use waitForSelector in freeze-path.spec.ts

* refactor: Improve time and use waitForSelector in freeze-path.spec.ts

* fromat code

* Refactor freeze.spec.ts: Remove unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants