Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unnecessary wait timeouts in chat components tests #4605

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

anovazzi1
Copy link
Contributor

this pr improves the test performance

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 14, 2024
@ogabrielluiz ogabrielluiz changed the title refactor: Remove unnecessary wait timeouts in chatInputOutputUser-shard-0.spec.ts refactor: Remove unnecessary wait timeouts in chat components tests Nov 14, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 14, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) November 14, 2024 19:04
@anovazzi1 anovazzi1 merged commit 076bc31 into main Nov 14, 2024
18 checks passed
@anovazzi1 anovazzi1 deleted the chatInputOutputUser-ShardImprove branch November 14, 2024 19:20
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…angflow-ai#4605)

* refactor: Remove unnecessary wait timeouts in chatInputOutputUser-shard-0.spec.ts

* update timer limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants