-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor loading of main page, use new Sidebar in main page, fix small UI bugs #4451
Merged
+694
−628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anovazzi1
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
… small UI bugs (langflow-ai#4451) * Tighten space between main page sidebar buttons * Fixed skeleton size * Added playground button back * Updated no components and flows state * Update default icon to Workflow * Fixed size of list cards * Removed browse store * Removed playground button * Removed black background from empty folder state * Update empty state color * Fix color of empty state * fix text not selectable * updated border color * added shadow only on hover * Remove JSON from Download JSON * Fixed colors and weight of tabs on home page * Fixed padding on list and grid components * Update icons that take long to load * Fixed icon and bg color for home tiles * Removed unused code * removed placeholder data for skeleton to not appear on first load * Make onSuccess refetch the queries so that the loading waits for it * Removed unused divs on foldersidebarnav * Refactor sidebar buttons to use new shadcn sidebar * Created skeletons for folder, grid and list * Added new sidebar size * Use new sidebar button on header and implemented animation * Changed icon to getIcon * Added sidebar provider and fixed loading states of the main page * Removed folder buttons on emptyPage * Fixed foldername to appear immediatly, and fixed loading states for the folders * Removed unused state from folders store * Removed unused states from folders store type * Added new icon * fixed modals component to not show a trash icon * Changed icons to load immediatly * Added empty folder condition to not display header info * Added conditions to show loading state until everything loads * Created empty folder state * Changed empty page to correct colors * Added skeletons while flows of the folder are loading * Removed shadow from text * Fixed font chivo taking long time to load * Fix adding new folder not redirecting * [autofix.ci] apply automated fixes * Fixed colors and paddings on list and grid components * Re added tooltips to upload and create folders * fix input for name editing * Fix tests --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend components and styles, particularly focusing on the
SideBarFoldersButtonsComponent
and related files. Key changes include refactoring import statements, modifying component props and states, and updating UI elements for better user experience and code maintainability.Component Refactoring and State Management:
src/frontend/src/components/folderSidebarComponent/components/sideBarFolderButtons/index.tsx
: Refactored to useuseLocation
forpathname
anduseFolderStore
forfolders
state. Removed redundant props and added new state management hooks. [1] [2]src/frontend/src/components/folderSidebarComponent/index.tsx
: Removed unused imports and simplified the component structure by removingHorizontalScrollFadeComponent
. [1] [2]UI and Styling Updates:
src/frontend/index.html
: Consolidated font import links into a single line for better readability.src/frontend/src/components/folderSidebarComponent/components/sideBarFolderButtons/index.tsx
: Updated various UI elements, including button variants, sidebar structure, and loading states. [1] [2]src/frontend/src/modals/templatesModal/components/TemplateCardComponent/index.tsx
: Modified background and icon styles for better visual feedback on hover and focus.API and Query Adjustments:
src/frontend/src/controllers/API/queries/flows/use-post-add-flow.ts
: Addedicon
property to theIPostAddFlow
interface and included it in the mutation payload. [1] [2]src/frontend/src/controllers/API/queries/folders/use-post-folders.ts
: ChangedonSettled
toonSuccess
in mutation options to ensure folders are refetched on successful post.Minor Fixes and Improvements:
src/frontend/src/components/folderSidebarComponent/components/sidebarFolderSkeleton/index.tsx
: Adjusted the skeleton loader height and padding for better alignment.src/frontend/src/pages/MainPage/components/dropdown/index.tsx
: Simplified the download menu item text.