Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rewrite regex to support latest yq version #44

Merged
merged 1 commit into from
May 17, 2024

Conversation

navneet-bairwal
Copy link
Contributor

@navneet-bairwal navneet-bairwal commented May 16, 2024

rewrite regex to support the new yq release, current build script is impacted by mikefarah/yq#1997

rewrite regex to support the new yq version
@pusher-robot
Copy link

Comparison of deploy-pr/env-dev afea35 to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
rename to Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 5d99f90..0a23436 100644
--- a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9114384026.2
+        - image: nginx:1.9114424915.0
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev afea35 to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
rename to Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 5d99f90..f451a17 100644
--- a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9114384026.2
+        - image: nginx:1.9114424915.1
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev afea35 to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
similarity index 96%
rename from Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
rename to Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 5d99f90..7ae785e 100644
--- a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9114384026.2
+        - image: nginx:1.91144249152.0
           name: nginx
           ports:
             - containerPort: 80

@pusher-robot
Copy link

Comparison of deploy-pr/env-dev afea35 to proposed changes to env/dev in this PR

Diff output
diff --git a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
similarity index 97%
rename from Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
rename to Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 5d99f90..8d32e8a 100644
--- a/Deployment-apps_v1-n:g<i>n|x-n*g?inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.9114384026.2
+        - image: nginx:1.9114424915.2
           name: nginx
           ports:
             - containerPort: 80

Copy link
Contributor

@domdepasquale domdepasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex is working for me

@navneet-bairwal navneet-bairwal merged commit 45f85cb into main May 17, 2024
4 checks passed
@navneet-bairwal navneet-bairwal linked an issue May 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yq fails to parse the regex with "\\"
3 participants