New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty env properly #27

Merged

highb merged 5 commits into main from handle-empty-env

Aug 14, 2023

Contributor

highb commented Aug 14, 2023

No description provided.


          Handle empty env properly

62fb1e8

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 73dfe1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 27c8f99..715af00 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5830186457.2
+        - image: nginx:1.5859451180.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 73dfe1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 27c8f99..dfd9b8b 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5830186457.2
+        - image: nginx:1.5859451180.1
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 73dfe1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 27c8f99..e216728 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5830186457.2
+        - image: nginx:1.58594511802.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 73dfe1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 27c8f99..2b9e43e 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5830186457.2
+        - image: nginx:1.5859451180.2
           name: nginx
           ports:
             - containerPort: 80

highb added 2 commits

August 14, 2023 12:02


          Use mktemp to make temp dir instead of relying on /tmp

b0cc62a


          Add all . when all files are removed

1f3d5dd

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Git Diff is too large to display in a comment.

Please check the logs.

2 similar comments

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Git Diff is too large to display in a comment.

Please check the logs.

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Git Diff is too large to display in a comment.

Please check the logs.


          Add render dir as env output

e42898d

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 2b9e43e..303ca70 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859451180.2
+        - image: nginx:1.5859812975.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 2b9e43e..2f1dead 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859451180.2
+        - image: nginx:1.5859812975.1
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 2b9e43e..9ebdef0 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859451180.2
+        - image: nginx:1.58598129752.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev e239d1 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index 2b9e43e..d07f4f3 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859451180.2
+        - image: nginx:1.5859812975.2
           name: nginx
           ports:
             - containerPort: 80


          linting

6da7423

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 72c111 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index d07f4f3..faf7106 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859812975.2
+        - image: nginx:1.5860449689.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 72c111 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index d07f4f3..3e96a2c 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859812975.2
+        - image: nginx:1.5860449689.1
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 72c111 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index d07f4f3..738160f 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859812975.2
+        - image: nginx:1.58604496892.0
           name: nginx
           ports:
             - containerPort: 80

pusher-robot commented Aug 14, 2023

Comparison of deploy-pr/env-dev 72c111 to proposed changes to env/dev in this PR

Diff output

diff --git a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
index d07f4f3..933089a 100644
--- a/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
+++ b/Deployment-apps_v1-n_g_i_n_x-n_g_inx.yaml
@@ -29,7 +29,7 @@ spec:
         app: nginx
     spec:
       containers:
-        - image: nginx:1.5859812975.2
+        - image: nginx:1.5860449689.2
           name: nginx
           ports:
             - containerPort: 80

NickAdolf approved these changes

View reviewed changes

highb merged commit 1011624 into main

highb deleted the handle-empty-env branch

August 14, 2023 21:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet