crictl stats: complain if user is not root #427
Conversation
$ ./bin/crictl stats FATA[0000] You're probably not root, your effective user id is 1000 $ sudo ./bin/crictl stats CONTAINER CPU % MEM DISK INODES 07ac205b107e5 0.00 2.273MB 0B 0 Signed-off-by: Lokesh Mandvekar <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lsm5 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
|
@mrunalp PTAL |
| @@ -82,6 +82,10 @@ var statsCommand = cli.Command{ | |||
| }, | |||
| Action: func(context *cli.Context) error { | |||
| var err error | |||
| if userID := os.Geteuid(); userID != 0 { | |||
| logrus.Fatalf("You're probably not root, your effective user id is %d", userID) | |||
There was a problem hiding this comment.
nit: We could probably say "Root privileges required to connect to cri socket, your effective user id is %d"
|
We can close this in favor of #428 |
$ ./bin/crictl stats
FATA[0000] You're probably not root, your effective user id is 1000
$ sudo ./bin/crictl stats
CONTAINER CPU % MEM DISK INODES
07ac205b107e5 0.00 2.273MB 0B 0
Signed-off-by: Lokesh Mandvekar [email protected]