Set version based on git tags. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
yujuhong
reviewed
Jul 11, 2018
pkg/version/version.go
Outdated
| package version | ||
|
|
||
| // Version holds the complete version number. Filled in at linking time. | ||
| var Version = "1.11.0+unknown" |
There was a problem hiding this comment.
Do we need to keep updating this Version?
There was a problem hiding this comment.
That's how containerd does it. We can keep this as a simple unknown string. :)
There was a problem hiding this comment.
This looks like a placeholder so I just wondered what we're going to do with it
There was a problem hiding this comment.
I'll change this to unknown.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
set-version-with-git-tag
branch
from
60ed6e6 to
01e710e
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
Apply LGTM based on #339 (comment) |
Random-Liu
added
the
lgtm
|
LGTM. |
This was referenced Jul 13, 2018
Closed
feiskyer
added a commit
that referenced
this pull request
Jul 13, 2018
Cherrypick #339 to release-1.11.
|
@Random-Liu does |
|
yep, @ncdc would you like make a PR for that? |
|
Sure, I can do it today
…On Wed, Aug 8, 2018 at 10:15 PM Pengfei Ni ***@***.***> wrote:
yep, @ncdc <https://github.com/ncdc> would you like make a PR for that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#339 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABYhoqZ4swJXfeqc2CXjOELKi88vWzks5uO5sxgaJpZM4VL6h4>
.
|
|
PR is #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to release a 1.11.1 from
release/1.11. However, I don't know whether I should only update the version number inrelease/1.11or update bothrelease/1.11and master.If we only update
release/1.11, master will still stay at1.11.0.But if we update both, master isn't actually at
1.11.1.This PR changes to use
git tagsinstead, which contains commit number for non-tag commits.@yujuhong @feiskyer
Signed-off-by: Lantao Liu [email protected]