Add crictl update --oom-score-adj flag

[saschagrunert]

What type of PR is this?

/kind feature

What this PR does / why we need it:

We have not used the value for the container update since now, which is now being added for feature completeness.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

@kubernetes-sigs/cri-tools-maintainers

Does this PR introduce a user-facing change?

Added `crictl update --oom-score-adj` flag.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SergeyKanzhelev]

Is it a revert of of #279?

[saschagrunert]

Is it a revert of of #279?

Oh, yes. I'm wondering why we should not have flags for mainly all available runtime update fields. There are also others missing:

https://github.com/kubernetes/cri-api/blob/3dd84b8b2b65ecdf2087863f2e028266cfa46dcb/pkg/apis/runtime/v1/api.proto#L849-L855

There are also other runtimes like crun and youki. 🤔

[SergeyKanzhelev]

There are also other runtimes like crun and youki. 🤔

I am not sure what is the right way to do here. Did you want it for completeness? Or some scenario is missing?

[Karthik-K-N]

From perspective of Node Resource Hot Plug KEP, where we are planning to utilize UpdateContainerResources CRI API to update the running container with updated oom_score_adj and swap limit (already supported), We would like to have this feature added and later integrate it with UpdateContainerResources CRI API so we will be able to update the oom_score_adj for container. Thanks.

[SergeyKanzhelev]

From perspective of Node Resource Hot Plug KEP, where we are planning to utilize UpdateContainerResources CRI API to update the running container with updated oom_score_adj and swap limit (already supported), We would like to have this feature added and later integrate it with UpdateContainerResources CRI API so we will be able to update the oom_score_adj for container. Thanks.

/lgtm

I guess we will be ok to return error if not supported on some runtimes

[Karthik-K-N]

From perspective of Node Resource Hot Plug KEP, where we are planning to utilize UpdateContainerResources CRI API to update the running container with updated oom_score_adj and swap limit (already supported), We would like to have this feature added and later integrate it with UpdateContainerResources CRI API so we will be able to update the oom_score_adj for container. Thanks.

/lgtm

I guess we will be ok to return error if not supported on some runtimes

Yeah, Thank you.