Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut cri-tools v1.17.0 #558

Closed
feiskyer opened this issue Dec 9, 2019 · 15 comments · Fixed by #564
Closed

Cut cri-tools v1.17.0 #558

feiskyer opened this issue Dec 9, 2019 · 15 comments · Fixed by #564

Comments

@feiskyer
Copy link
Member

feiskyer commented Dec 9, 2019

work items include:

  • Update kubernetes vendor to v1.17.0
  • Build binaries by make release and update release notes

@saschagrunert @Random-Liu anything more would you like to include in this release?

@saschagrunert would you like to work on this release?

@saschagrunert
Copy link
Member

Hey, sure I can take care of the release this time. Can anyone support me with the windows binaries?

Otherwise I would check If I can find a windows machine somewhere.

@feiskyer
Copy link
Member Author

feiskyer commented Dec 9, 2019

The binaries building doesn't need a windows machine

@saschagrunert
Copy link
Member

Sounds good, I'll take care as soon as v1.17.0 is available.

@saschagrunert
Copy link
Member

@feiskyer do we want to maintain release-branches as well? We stopped doing that for 1.16.

@feiskyer
Copy link
Member Author

since the CRI API doesn't change, we don't need to maintain a new branch.

@saschagrunert
Copy link
Member

@feiskyer I'm ready to publish the release, but lacking permissions in this repository to edit the tags accordingly. Can you provide me the set of permissions?

@feiskyer
Copy link
Member Author

@saschagrunert you need to be admin to edit tags, could you apply at org? Have you got the release notes ready? I can do tag publishing.

@saschagrunert
Copy link
Member

@saschagrunert you need to be admin to edit tags, could you apply at org? Have you got the release notes ready? I can do tag publishing.

I'll create the issue in the next minutes for the org. These are the notes so far:

# cri-tools v1.17.0

cri-tools v1.17.0 mainly focuses on bug fixes and stability improvements.

# CRI CLI (crictl)

- #562 Bump cri-tools version in markdown docs
- #561 Vendor kubernetes v1.17.0
- #557 Update golang dependencies
- #556 Print the previous log of the container(just like kubectl)
- #555 Add rmi --prune command
- #553 Update README.md to contain latest version hint
- #552 Download golangci-lint via wget
- #550 Fix pod and container name filter for JSON/YAML output
- #545 Fix e2e tests by pinning CRI-O and conmon
- #544 Fixed Tim St. Clair's username
- #537 Add fish shell completion support

@feiskyer
Copy link
Member Author

@saschagrunert let's include #563 in the release, it fixes a bug of force removal

@saschagrunert
Copy link
Member

Sure sounds good. :)

@feiskyer
Copy link
Member Author

Release cut https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.17.0.

@Random-Liu could you help to upload GCS release?

@saschagrunert
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member Author

done by @Random-Liu
/close

@k8s-ci-robot
Copy link
Contributor

@feiskyer: Closing this issue.

In response to this:

done by @Random-Liu
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants