Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs should not report error when container don't set logpath. #177

Closed
yanxuean opened this issue Nov 3, 2017 · 0 comments
Closed

logs should not report error when container don't set logpath. #177

yanxuean opened this issue Nov 3, 2017 · 0 comments

Comments

@yanxuean
Copy link
Contributor

yanxuean commented Nov 3, 2017

Or indicate the user that the we cann't output logs because the container don't set logpath.


root@ubuntu:/home/cloud/test# crictl logs 331
FATA[0000] Get log path of container failed
root@ubuntu:/home/cloud/test#
root@ubuntu:/home/cloud/test#
root@ubuntu:/home/cloud/test# crictl inspect 331
DEBU[0000] ContainerStatusRequest: &ContainerStatusRequest{ContainerId:331,}
DEBU[0000] ContainerStatusResponse: &ContainerStatusResponse{Status:&ContainerStatus{Id:3317b118e40044e2ea8981e08bcece969f3b6533c087daeef0aa3f1bb9d2570c,Metadata:&ContainerMetadata{Name:busybox2,Attempt:0,},State:CONTAINER_RUNNING,CreatedAt:1509674580490484539,StartedAt:1509674623756901309,FinishedAt:0,ExitCode:0,Image:&ImageSpec{Image:busybox,},ImageRef:docker.io/library/busybox@sha256:0b408ce12dfae8721f5640f16f90f6592cda42a5bbc0a4ee2b31ee18c1b8985a,Reason:,Message:,Labels:map[string]string{},Annotations:map[string]string{},Mounts:[],LogPath:,},}

yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 8, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant