Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Loading Skeleton for the AddBlog Section #446

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

AMS003010
Copy link
Contributor

Summary

This PR provides a Loading Skeleton for the AddBlog section so that the user has a seamless experience

Description

AddBlogPostSkeleton Component has been added and has been used to replace the previous Loader component that was used.

Images

screenshot

Issue(s) Addressed

Closes #445
Enter the issue number of the bug(s) that this PR fixes

Prerequisites

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 3:38pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 3:38pm

Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @AMS003010
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

@krishnaacharyaa
Copy link
Owner

image

So now according to your logic, whereever the RequireAuth is used I'll get your this skeleton loading ....!!

@AMS003010
Copy link
Contributor Author

Sorry, I'll fix that

@AMS003010
Copy link
Contributor Author

Actually umashri_meti wants to fix the rest....
Can we do that in a single PR

@krishnaacharyaa
Copy link
Owner

@umashri_meti

@krishnaacharyaa
Copy link
Owner

@MetiUmashri kindly work on top of this PR if you wanna do a combined PR @AMS003010 yes it is possible, please aim to close this soon. As there is nothing much to be done

@MetiUmashri MetiUmashri mentioned this pull request Jul 13, 2024
@krishnaacharyaa
Copy link
Owner

image

So now according to your logic, whereever the RequireAuth is used I'll get your this skeleton loading ....!!

@AMS003010 @MetiUmashri this is still not solved even in the newly raised PR :)

@krishnaacharyaa krishnaacharyaa merged commit 300152f into krishnaacharyaa:main Jul 20, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Absence of a Proper Loading skeleton for the AddBlog Section Centralised Error Handling
2 participants