feat-#419: Added post editing functionality #443

devsharmagit · 2024-07-08T14:04:12Z

Summary

This PR completes the post editing functionality in the application.

Description

A separate form component is created and used to create two pages. Add blog page and edit blog page.

Images

2024-07-08.19-29-46.mp4

Issue(s) Addressed

Closes #419

Prerequisites

Have you followed all the CONTRIBUTING GUIDELINES?

vercel · 2024-07-08T14:04:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wanderlust	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 6:22am
wanderlust-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 6:22am

github-actions · 2024-07-08T14:04:28Z

Hey @devsharmagit! Thanks for sticking to the guidelines! High five! 🙌🏻

krishnaacharyaa

LGTM functionality wise, some reviews if you can address. That would be great :)

krishnaacharyaa · 2024-07-09T05:30:24Z

backend/middlewares/post-middleware.js

@@ -11,12 +11,12 @@ export const isAuthorMiddleware = async (req, res, next) => {
    }

    console.log(post.authorId, userId);
-    if (post.authorId.toString() !== userId) {
+    if (post?.authorId?.toString() !== userId) {
      return res


Why do we need ? here? isn't authorId mandatory for the post? ideally we are not supposed to use ?

krishnaacharyaa · 2024-07-09T05:31:13Z

backend/middlewares/post-middleware.js

      return res
        .status(HTTP_STATUS.FORBIDDEN)
        .json({ message: RESPONSE_MESSAGES.POSTS.NOT_ALLOWED });
    }
-    next();
+    return next();
  } catch (error) {


return next()? can we do both in one ? I don't think so it is redundant it should be either return or next()

krishnaacharyaa · 2024-07-09T05:34:16Z

frontend/src/pages/details-page.tsx

            <img
              alt="white"
              src={navigateBackWhiteIcon}
              className="active:scale-click h-5 w-10"
              onClick={() => navigate(-1)}
            />
+
+            {(post?.authorId === userData?._id || userData?.role === 'ADMIN') && (
+              <div className="flex gap-4">


This is one way, but now that we have access token , please use it, instead of id

here I am checking if the logged-in user is the author of the post or not.
I don't think it's possible to do with the access token

@devsharmagit https://www.youtube.com/watch?v=Yh5Lil03tpI first 6mins give it a look. That's the reason we have introduced the access token, it will fail in backend because it is handled there, but i want even the frontend to have some intelligence

@devsharmagit are you working on this? This PR looks very stale

Can we aim to close this within couple of days, picking it

I am not able to get the changes you are requesting here.
I am getting user data from the user state. why I use access token instead of user state?

@siddharthisrani can you please help @devsharmagit

@devsharmagit please sync with @siddharthisrani and @Sukomal07 and close this

krishnaacharyaa · 2024-07-09T05:35:44Z

frontend/src/pages/edit-blog.tsx

+  const navigate = useNavigate();
+
+  if (post?.authorId && userData?._id) {
+    if (userData?.role === 'USER' && post?.authorId !== userData?._id) {


Logic looks very complicated and difficult to comprehend, can you simplify

krishnaacharyaa · 2024-07-09T05:36:40Z

frontend/src/pages/signup-page.tsx

@@ -67,7 +67,7 @@ function Signup() {
    <div className="flex-grow cursor-default bg-white py-4 dark:bg-dark-card">
      <div className="m-4 mb-4 flex justify-center">
        <div className="flex w-full items-center justify-center">
-          <h2 className="text-center text-lg font-bold text-black dark:text-dark-primary w-2/4 pl-2 sm:text-xl md:w-3/4 md:pl-48">
+          <h2 className="w-2/4 pl-2 text-center text-lg font-bold text-black dark:text-dark-primary sm:text-xl md:w-3/4 md:pl-48">
            Sign up to WanderLust


remove sm: wherever you have used

i have not changed anything here
preettier just "w-2/4 pl-2" in front of classname

krishnaacharyaa · 2024-07-09T05:38:26Z

frontend/src/types/post-type.tsx

@@ -6,6 +6,7 @@ type Post = {
  timeOfPost: string;
  description: string;
  categories: string[];
+  authorId?: string;
 };


authorId? -> authorId
Okay now I know why you used ?

For this if we require to change and refill the db we will
Let's not have ?

some posts in db does not have authorId that's why it's being added optional

@devsharmagit so said

For this if we require to change and refill the db we will

Let's add to everything and change the sample-posts.json wala file

devsharmagit · 2024-07-09T06:21:56Z

pushed the requested changes

krishnaacharyaa · 2024-07-12T05:58:57Z

@devsharmagit any progress ?

krishnaacharyaa · 2024-07-27T05:16:33Z

@devsharmagit please see the attached video above in the comments, you'll get a good picture about stuffs and let's please try to close it this weekend, of required take help of @siddharthisrani he has recently worked on in this
@siddharthisrani can you please help him if required the local storage part

krishnaacharyaa · 2024-07-27T17:40:27Z

@devsharmagit acknowledgment please

krishnaacharyaa · 2024-07-29T18:51:03Z

@devsharmagit you there ?

devsharmagit · 2024-07-30T02:59:18Z

how do i contact @siddharthisrani ?

krishnaacharyaa · 2024-07-30T03:24:49Z

Figure out @devsharmagit 🙂
GitHub ping him , or connect to him over linkendin, see his profile

krishnaacharyaa · 2024-07-30T03:25:22Z

He might be in discord also
Figure out buddy

devsharmagit · 2024-07-30T03:44:03Z

@krishnaacharyaa
instagram link was there on his github profile
i messaged him there

krishnaacharyaa · 2024-07-30T03:57:17Z

Don't be dependent see the video shared and figure out...
Basically we should play with tokens not local storage...
Take the challenge and do it ...
Complain thoo sab kartte hei 😉

devsharmagit · 2024-07-30T04:37:41Z

@krishnaacharyaa
can you check useAuthData.ts ?
i dont think that we are using local storage. we are using token there

krishnaacharyaa · 2024-08-03T18:11:28Z

Cool hei tho fir, not sure why i saw it being taken from the localstorage. Sorry for the miss

krishnaacharyaa

Cool hei, thanks for the changes, let's check in the production, and if there is any changes, lets pick it up and fix it.

feat-krishnaacharyaa#419: added post edit page

623c07a

vercel bot deployed to Preview – wanderlust July 8, 2024 14:04 View deployment

vercel bot deployed to Preview – wanderlust-backend July 8, 2024 14:05 View deployment

krishnaacharyaa requested changes Jul 9, 2024

View reviewed changes

feat-krishnaacharyaa#419: edits

6b7161e

vercel bot deployed to Preview – wanderlust-backend July 9, 2024 06:21 View deployment

vercel bot deployed to Preview – wanderlust July 9, 2024 06:22 View deployment

krishnaacharyaa approved these changes Aug 3, 2024

View reviewed changes

krishnaacharyaa merged commit e298b45 into krishnaacharyaa:main Aug 3, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat-#419: Added post editing functionality #443

feat-#419: Added post editing functionality #443

devsharmagit commented Jul 8, 2024

vercel bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024

krishnaacharyaa left a comment

krishnaacharyaa Jul 9, 2024

krishnaacharyaa Jul 9, 2024

krishnaacharyaa Jul 9, 2024

devsharmagit Jul 9, 2024

krishnaacharyaa Jul 9, 2024

krishnaacharyaa Jul 23, 2024

krishnaacharyaa Jul 23, 2024

devsharmagit Jul 24, 2024

krishnaacharyaa Jul 25, 2024

krishnaacharyaa Jul 9, 2024

krishnaacharyaa Jul 9, 2024

devsharmagit Jul 9, 2024

krishnaacharyaa Jul 9, 2024

devsharmagit Jul 9, 2024

krishnaacharyaa Jul 9, 2024

devsharmagit commented Jul 9, 2024

krishnaacharyaa commented Jul 12, 2024

krishnaacharyaa commented Jul 27, 2024

krishnaacharyaa commented Jul 27, 2024

krishnaacharyaa commented Jul 29, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Aug 3, 2024

krishnaacharyaa left a comment

feat-#419: Added post editing functionality #443

feat-#419: Added post editing functionality #443

Conversation

devsharmagit commented Jul 8, 2024

Summary

Description

Images

Issue(s) Addressed

Prerequisites

vercel bot commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024

krishnaacharyaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devsharmagit commented Jul 9, 2024

krishnaacharyaa commented Jul 12, 2024

krishnaacharyaa commented Jul 27, 2024

krishnaacharyaa commented Jul 27, 2024

krishnaacharyaa commented Jul 29, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Jul 30, 2024

devsharmagit commented Jul 30, 2024

krishnaacharyaa commented Aug 3, 2024

krishnaacharyaa left a comment

Choose a reason for hiding this comment

vercel bot commented Jul 8, 2024 •

edited

Loading