Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#362: Anchor tag added in the logo #375

Merged
merged 4 commits into from
Jun 2, 2024
Merged

fix-#362: Anchor tag added in the logo #375

merged 4 commits into from
Jun 2, 2024

Conversation

RamakrushnaBiswal
Copy link
Contributor

@RamakrushnaBiswal RamakrushnaBiswal commented May 29, 2024

Summary

anchor tag added in the logo

Description

Explain in detail what this PR is all about. This should include the problem you're solving, the approach taken, and any technical details that reviewers need to know.

Images

bug4.mp4

Issue(s) Addressed

#362 solved

Prerequisites

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 4:50am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 4:50am

Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @RamakrushnaBiswal
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @RamakrushnaBiswal
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

@krishnaacharyaa
Copy link
Owner

Kindly read what is already reviewed @RamakrushnaBiswal

@krishnaacharyaa
Copy link
Owner

By the bot @RamakrushnaBiswal

@RamakrushnaBiswal RamakrushnaBiswal changed the title anchor tag added in the logo fix-#362:anchor tag added in the logo May 31, 2024
Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @RamakrushnaBiswal
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

@RamakrushnaBiswal RamakrushnaBiswal changed the title fix-#362:anchor tag added in the logo fix-#362 : Anchor tag added in the logo May 31, 2024
Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @RamakrushnaBiswal
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

@RamakrushnaBiswal RamakrushnaBiswal changed the title fix-#362 : Anchor tag added in the logo fix-#362: Anchor tag added in the logo May 31, 2024
Copy link

Hey @RamakrushnaBiswal! Thanks for sticking to the guidelines! High five! 🙌🏻

@RamakrushnaBiswal
Copy link
Contributor Author

@krishnaacharyaa done😮‍💨

@krishnaacharyaa
Copy link
Owner

@RamakrushnaBiswal do we actually require tag? Can we come up with a alternate tag which react recommends?
And kindly follow the commit guidelines... :)

@RamakrushnaBiswal
Copy link
Contributor Author

Link ? @krishnaacharyaa

@krishnaacharyaa
Copy link
Owner

Link ? @krishnaacharyaa

Go for it

@RamakrushnaBiswal
Copy link
Contributor Author

@krishnaacharyaa done bro

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@krishnaacharyaa krishnaacharyaa merged commit 055bdb8 into krishnaacharyaa:main Jun 2, 2024
3 checks passed
@RamakrushnaBiswal RamakrushnaBiswal deleted the bunty-dev branch June 2, 2024 11:18
@RamakrushnaBiswal
Copy link
Contributor Author

hi @krishnaacharyaa Thank you for accepting the PR ,please add some labels and assignee for me 🥹🥹

@krishnaacharyaa krishnaacharyaa added the gssoc Issue can be taken under GSSoC label Jun 2, 2024
@RamakrushnaBiswal
Copy link
Contributor Author

RamakrushnaBiswal commented Jun 2, 2024

@krishnaacharyaa labels like lavel 1,lavel 2 ,lavel 3

@krishnaacharyaa
Copy link
Owner

As it is small change and you havent followed community guidelines i havent put the label @RamakrushnaBiswal

@RamakrushnaBiswal
Copy link
Contributor Author

@krishnaacharyaa its okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Issue can be taken under GSSoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralised Error Handling
2 participants