fix-#257: Implemented show/hide password functionality #364
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @rushil-b-patel! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
Hey @rushil-b-patel! Thanks for sticking to the guidelines! High five! 🙌🏻 |
backend/app.js
Outdated
| @@ -16,7 +16,7 @@ app.use(cors({ | |||
| credentials: true | |||
| })); | |||
| app.use(express.json()); | |||
| app.use(express.urlencoded({ extended: true })); | |||
| app.use(express.urlencoded()); | |||
There was a problem hiding this comment.
this is what I was saying that I commited that payload vala change but I tried to undo that commit through revert but I don't I didn't find my way but managed to undo in this commit. So it will the same the app.js (backend) won't change.
There was a problem hiding this comment.
payload vala change, i didn't get.
But if this is unexpected and want to get back, make a new commit reverting the changes
There was a problem hiding this comment.
umm what I was saying is that I made a commit changing the app.use(express.urlencoded()); to app.use(express.urlencoded({ extended: true })); but I revert the changes while addressing this password vala issue so in this commit it will get back to normal app.use(express.urlencoded()); which is already there in the main branch, so it won't affect.
There was a problem hiding this comment.
Oh okay, you are saying previously you were the one who made this changes is it?
There was a problem hiding this comment.
umm what I was saying is that I made a commit changing the app.use(express.urlencoded()); to app.use(express.urlencoded({ extended: true }));
This never happened in the main branch, it might be in the private branch
There was a problem hiding this comment.
Just change it back to this so that I can merge
app.use(express.urlencoded({ extended: true }));
Just do this,
There was a problem hiding this comment.
yes it was in private repo.
You want to change from app.use(express.urlencoded()); to this app.use(express.urlencoded({ extended: true }));..? @krishnaacharyaa
There was a problem hiding this comment.
any update...? @krishnaacharyaa
There was a problem hiding this comment.
I have updated long time ago with the emoji
| className="absolute inset-y-0 right-0 flex items-center pr-3 text-sm leading-5" | ||
| > | ||
| <img src={passwordVisible ? EyeOffIcon : EyeIcon} alt="Toggle-visibility" className="w-5 h-5" /> | ||
| </button> |
There was a problem hiding this comment.
{passwordVisible ? EyeOffIcon : EyeIcon} ideally should be {passwordVisible ? EyeIcon : EyeOffIcon}
There was a problem hiding this comment.
ohh My bad, yes you are correct. Let me change that...
| type="button" | ||
| onClick={() => setPasswordVisible(!passwordVisible)} | ||
| className="absolute inset-y-0 right-0 flex items-center pr-3 text-sm leading-5" | ||
| > |
There was a problem hiding this comment.
Kindly make sure if this works in the mobile screen as well, can you add the video recorded for the mobile screen as well
There was a problem hiding this comment.
sure @krishnaacharyaa
|
Hey @rushil-b-patel! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
good to go...! @krishnaacharyaa |
|
Good to go.. @krishnaacharyaa ...! |
Summary
Implemented the show/hide password functionality with state & react icons.
Description
Images
passwordVisibility.webm
(it supports the mobile responsive also so no need to change any thing :) )
Issue(s) Addressed
Closes #257
Prerequisites