Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#220: Fixed Heights of All Post Section's cards #357

Conversation

Alen-Scaria1516
Copy link
Contributor

Summary

Fixed the different height issues of All post sections.

Description

The cards had different heights, causing inconsistency in the design. So added a Text Truncation (...) property on overflow on the Category Pill and sliced the category array into just first 3 pills, so that it will stay in one line and won't grow to the next line to increase the size of the card.

Images

Screenshot 2024-05-25 002517

Issue(s) Addressed

Closes #220

Prerequisites

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 6:59pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 6:59pm

Copy link

Hey @Alen-Scaria1516! Thanks for sticking to the guidelines! High five! 🙌🏻

@Alen-Scaria1516
Copy link
Contributor Author

@krishnaacharyaa Sorry, I had to close the old PR, cuz I had to delete that branch. I hope that it's fine 😇

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @Alen-Scaria1516 :)

@krishnaacharyaa krishnaacharyaa merged commit 18326ae into krishnaacharyaa:main May 25, 2024
5 checks passed
@Alen-Scaria1516
Copy link
Contributor Author

@krishnaacharyaa sorry to bother u. My contribution has not been reflected in GSSOC Leaderboard, missing

  • my name as Assigness in the PR
  • labels on PR {gssoc and level1}

Would you be kind enough to add these so that my work would be reflected on the LeaderBoard? Thank You 😇

@krishnaacharyaa krishnaacharyaa added gssoc Issue can be taken under GSSoC level2 labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Issue can be taken under GSSoC level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Different Cards under all posts are of different height ,.
2 participants