-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated README.md #304
updated README.md #304
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All left aligned please.
And make sure every emojis are bouncing and animated if possible like the open source wala muscle
And instead of :- make it :
There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1
sure |
done with these changes ,let me know about the other changes @krishnaacharyaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor changes
And discord link is invalid |
changed accoding to the changes requests.
@krishnaacharyaa have a look now , I think I have completed all the changes you want . |
Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1 |
Why is there some space in the right side not used in the contributions section? can we make it a little small, only a little @Meetjain1 |
okk done |
adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ? |
No we'll have to figure out, the gssoc has deployed our project in their some website, that link we'll have to put or else if you feel link mei doesn't look good. Convert the existing description like table of 2 columns , logo should span across 2 rows got it? @Meetjain1 |
okk done created a table |
updated as per requests
@krishnaacharyaa have a look now , I think no changes required now 🙃 |
@Meetjain1 , the link wala why did you change? I am not able to click anything? The previous one the content was all good, the blue underline and proper links and stuff, I wanted you to just change the heading from 💎 to 🔗. Rest all looks really good. |
arae mujhe laga aap ye change krne ko bole thae |
The previous one was good bro! Blue underline just heading Kindly change Once you raise new PR which follows the contributing guidelines I'll merge this Even I'm eager to get this changes in 😍😊 No more changes hopefully @Meetjain1 |
Haash ok 👍 |
completed
@krishnaacharyaa pr title checker ka issue aaraha hai kya hai ye ? |
@Meetjain1 slow down your horses, 5th time I'm saying take your time and raise new PR reading the 5 points in contributing guidelines. Once your PR follows the commits and PR title according to guidelines will merge this. |
@Meetjain1 pardon me, missed the new PR!. Closing this |
Summary
updated readme.md
Issue(s) Addressed
closes #263