refactor: Created a new header-layout file to segregate out header code. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with footer-layout
…to avoid the repeatation
…to avoid the repeatation
…to avoid the repeatation
…ains relative to component's content height
…ntrol, relative with other components content height
…ntrol, relative with other components content height
…ntrol, relative with other components content height
…ntrol, relative with other components content height
…ext with top blogs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krishnaacharyaa
requested changes
Apr 1, 2024
| return ( | ||
| <div | ||
| style={{ backgroundImage: `url(${bg})` }} | ||
| className="relative -mt-2 h-[460px] bg-cover bg-fixed bg-center" |
There was a problem hiding this comment.
Can you kindly refactor this to use bg-[url] kinda format, the tailwind supported one
There was a problem hiding this comment.
Created a PR with new branch.
PR:- #124
|
Declining as #124 duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces modular approach by separating header-code in a new 'header-layout' file rather than keeping into a single file (home-page).
Description
This PR isolates the header-related code from the home-page file and moves it into a new header-layout file, along with all imported modules. It then integrates this header-layout as a component within the home-page file.
Images
Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable
Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes
Prerequisites