Allows hook to prevent handler to be resolved #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the `before` hook to prevent the handler to be resolved by simply calling the `done` function by passing `false` as argument.
|
Awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the
beforehook to prevent the handler to be resolvedby simply calling the
donefunction by passingfalseas argument.To get test running in my local machine I need to run
npm run buildand replace theimport Navigo from '../../lib/navigo';byimport Navigo from '../../lib/navigo.min';because somehowlib/navigo.jsis not being updated innpm run build.Note: This PR does not resolve #57