Adding getLinkPath function #120

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.7.0
+
+* Adding `getLinkPath` function to cover [#120](https://github.com/krasimir/navigo/issues/120)
+
 ## 4.6.2
 
 * Fixing a bug in IE9 [#110](https://github.com/krasimir/navigo/pull/110)

README.md

@@ -294,6 +294,7 @@ You may provide hooks in two other cases:
 * `router.updatePageLinks()` - it triggers the `data-navigo` links binding process
 * `router.notFound(function)` - adding a handler for not-found URL (404 page)
 * `router.lastRouteResolved()` - returns an object with the format of `{ url: <string>, query: <string> }` matching the latest resolved route
+* `router.getLinkPath` - you may overwrite that function to provide a different mechanism for fetching paths from links which are currently on the page (with `data-navigo` attribute)
 
 There are couple of static properties. You'll probably never need to touch them but here're they:
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "navigo",
-  "version": "4.6.2",
+  "version": "4.7.0",
   "description": "A simple vanilla JavaScript router with a fallback for older browsers",
   "main": "lib/navigo.js",
   "jsnext:main": "src/index.js",

src/index.js

@@ -301,7 +301,7 @@ Navigo.prototype = {
     this._findLinks().forEach(link => {
       if (!link.hasListenerAttached) {
         link.addEventListener('click', function (e) {
-          var location = link.pathname;
+          var location = self.getLinkPath(link);
 
           if (!self._destroyed) {
             e.preventDefault();
@@ -344,6 +344,9 @@ Navigo.prototype = {
   lastRouteResolved() {
     return this._lastRouteResolved;
   },
+  getLinkPath(link) {
+    return link.pathname || link.getAttribute('href');
+  },
   _add: function (route, handler = null, hooks = null) {
     if (typeof route === 'string') {
       route = encodeURI(route);

test/spec/InBrowser.spec.js

@@ -352,4 +352,30 @@ describe('Given the Navigo library on the page', function () {
         .and.to.be.calledWith('answer=42');
     });
   });
+  describe('and the problem described in #120', function () {
+    it('should use a custom function for fetching link\'s url', function () {
+      var event = new MouseEvent('click', {
+        'view': window,
+        'bubbles': true,
+        'cancelable': true
+      });
+      var link = document.createElement('LINK');
+      var body = document.querySelector('body');
+
+      link.setAttribute('id', 'myLink');
+      link.setAttribute('href', 'overview/getting-started');
+      link.setAttribute('data-custom-url', 'foo/bar');
+      link.setAttribute('data-navigo', 'yes');
+      body.appendChild(link);
+
+      router = new Navigo(null, true);
+      router.getLinkPath = function (link) {
+        return link.getAttribute('data-custom-url');
+      };
+      link.dispatchEvent(event);
+
+      expect(window.location.href.split('#')[1]).to.be.equal('foo/bar');
+      body.removeChild(link);
+    });
+  });
 });