Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Editing/re-defining a macro causes duplicates to appear in the menu #907

Closed
VanessaE opened this issue Mar 10, 2018 · 3 comments
Closed

[2.x] Editing/re-defining a macro causes duplicates to appear in the menu #907

VanessaE opened this issue Mar 10, 2018 · 3 comments
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix commited Reproduced
Milestone
Release 2.0.0

Comments

@VanessaE
Copy link
Contributor

At commit eb6bd43

Define two or more macros
Close Pronterface and restart
Edit one of the macros and save
Check "Settings -> Macros" and you'll find two copies of each defined macro (i.e. including ones you didn't re-edit).
@VanessaE VanessaE changed the title Editing/re-defining a macro causes duplicates to appear in the menu [2.x] Editing/re-defining a macro causes duplicates to appear in the menu Mar 10, 2018
@kliment kliment added the 2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases label Mar 10, 2018
@hroncok
Copy link
Collaborator

hroncok commented Mar 20, 2018

Reproduced on 610f9ff. This is the log from terminal:

Created macro foo:

Macro 'foo' defined
Macro 'foo' defined

Created macro bar:

Macro 'bar' defined
Macro 'bar' defined

Restarted, edited macro foo:

Macro 'foo' defined
Macro 'foo' defined

@rockstorm101 rockstorm101 added this to the Release 2.0.0 milestone Mar 20, 2018
kliment added a commit that referenced this issue Mar 22, 2018
@kliment
Change DeleteItem to DestroyItem to remove entries from menu. Fixes #907
e30e0df
@kliment
Copy link
Owner

kliment commented Mar 22, 2018

Fixed in latest commit. @VanessaE please confirm it works correctly now.

@VanessaE
Copy link
Contributor Author

Seems to be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix commited Reproduced
Projects
None yet
Milestone
Release 2.0.0
Development

No branches or pull requests
4 participants
@kliment @VanessaE @hroncok @rockstorm101