Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset for Temperatures does not affect Selection on the main screen 02/2015 ver.) #676

Closed
Chrisu02 opened this issue Jun 14, 2015 · 5 comments

Comments

@Chrisu02
Copy link

I just noticed that when i change the temperatur values for bed/extruder ABS/PLA at the "Printer Settings" it does not change at the main screen.
there are always the 185/230 60/110 values.

at the older 03/2014 it does work normally.

@rockstorm101
Copy link
Collaborator

Confirmed.

  • OS: Windows 10 Pro
  • Printrun Version: 1.6.0

@xoan
Copy link
Contributor

xoan commented Apr 1, 2018

Still present in 2.0.0rc5

@az143
Copy link

az143 commented Nov 7, 2018

as far as i can tell from poring over the code of the 1.6.0 debian version (i've also checked current head, same issue but line 368),
it's line 349 in settings.py that looks for callbacks named '__whatever_cb', but what was actually setup for the temps reading from rc file is '_whatever_cb', ie. just one underscore. with that one character change i'm finally seeing the expected configured temperatures in the dropdown menus

--- settings.py.orig
+++ settings.py
@@ -346,7 +346,7 @@
         try:
             cb = None
             try:
-                cb = getattr(self, "__%s_cb" % key)
+                cb = getattr(self, "_%s_cb" % key)
             except AttributeError:
                 pass
             if cb is not None: cb(key, value)

@rockstorm101
Copy link
Collaborator

Wow! @az143 good catch! Could you please send a PR?

kliment added a commit that referenced this issue Sep 24, 2019
fix for issue #676, preset temperatures aren't read from the rc file
@rockstorm101
Copy link
Collaborator

Closing. Fixed by #971. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants