-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python bindings for PIDHandler #397
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice. I had mainly opened that issue as a reminder for myself not as a call to action ;)
What would be nice to check as well would be the constructors from frames, or from multiple collections via the static from
methods. However, they clash with the from
keyword from python. That was the main reason for me to not directly go to solve this ;) Would probably need some from_event
and from_collections
overloads on the c++ side to make things available on the python side in a working manner.
Adding the same creation functionality as is available in c++ in python via the |
5df4f0c
to
5ea943a
Compare
There seems to be some problems with a lifetime when using pythonized pid1 = handler.getPID(reco[0], 42)
pid1.value()
handler.getPID(reco[0], 42).value() Possibly related to AIDASoft/podio#642 |
I think a possible workaround for the problems with pythonized |
Co-authored-by: tmadlener <[email protected]>
5ea943a
to
25de8ec
Compare
If we are adding a dedicated python wrapper / interface here, that could also accommodate the necessary handling of the |
I'm not sure if I understand. The functions here are expecting to get a python wrapper for Frame and then get cppyy Frame object from it and use it with the functions expecting C++ Frame Do you mean you'd like to have reimplementation of C++ functions in python using Frame wrapper methods without reaching to C++ Frame directly? |
No, I was thinking that if we want the special handling of So now the actual question is: Can we make the |
I see. I tried hiding handling of |
BEGINRELEASENOTES
ENDRELEASENOTES
Python test is selected tests from C++ version
Closes #396