OrcID Link Support #233
Merged
OrcID Link Support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new OrcidLink component Update API to use JSONRPC2 param format Add ORCID tab to account page Add link creation workflow stub
Add OrcidLinkError component Update route for error handling
dauglyon
force-pushed
the
feature/orcidlink
branch
from
d8847d7 to
56f40c7
Compare
dauglyon
commented
Feb 12, 2025
There was a problem hiding this comment.
Layout changes to keep everything visually aligned
dauglyon
commented
Feb 12, 2025
There was a problem hiding this comment.
Layout changes to keep everything visually aligned
dauglyon
commented
Feb 12, 2025
There was a problem hiding this comment.
Should be future-proof as/if/when we add more orcid features
dauglyon
commented
Feb 13, 2025
src/features/account/Account.tsx
Outdated
There was a problem hiding this comment.
Added the three new tabs, also removed the tab state, as it is duplicated by the router. Used the router location to determine the active tab.
dauglyon
commented
Feb 13, 2025
There was a problem hiding this comment.
Add support for viewing expired Policies
dauglyon
commented
Feb 13, 2025
src/features/login/Policies.tsx
Outdated
There was a problem hiding this comment.
Add support for viewing expired Policies
dauglyon
commented
Feb 18, 2025
|
Reviewed today in Ui meeting |
|
Merging! BE service is up in prod, and I confirmed this PR works with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files have file-level gh comments explaining why they were modified.