fix requestId race condition and actually dispatch bool columnMeta #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauglyon
commented
May 14, 2024
Comment on lines
+228
to
+245
| dispatch( | ||
| setColumnMeta([ | ||
| collectionId, | ||
| context, | ||
| column.col_id, | ||
| { | ||
| type: 'bool', | ||
| key: column.col_id, | ||
| max_value: undefined, | ||
| min_value: undefined, | ||
| category: category.category, | ||
| description: column.description, | ||
| display_name: column.name, | ||
| filter_strategy: undefined, | ||
| enum_values: undefined, | ||
| }, | ||
| ]) | ||
| ); |
There was a problem hiding this comment.
The filters were not showing up because I forgot the dispatch...
dauglyon
commented
May 14, 2024
Comment on lines
+255
to
+257
| ? typeof current.value !== 'undefined' | ||
| ? Boolean(current.value) | ||
| : undefined |
There was a problem hiding this comment.
Fixes accidentally setting all filters to false if they were undefined
dauglyon
commented
May 14, 2024
Comment on lines
+1018
to
+1038
| // In order not to create a dependency loop when filter changes within the below effect, | ||
| // use a filter ref | ||
| const filterRef = useRef(filter); | ||
| filterRef.current = filter; | ||
|
|
||
| useEffect(() => { | ||
| let value; | ||
| if (selectValue === 'true') { | ||
| value = 1; | ||
| } else if (selectValue === 'false') { | ||
| value = 0; | ||
| } | ||
| dispatch(setFilter([collectionId, context, column, { ...filter, value }])); | ||
| }, [selectValue, collectionId, context, column, filter, dispatch]); | ||
| dispatch( | ||
| setFilter([ | ||
| collectionId, | ||
| context, | ||
| column, | ||
| { ...filterRef.current, value }, | ||
| ]) | ||
| ); | ||
| }, [selectValue, collectionId, context, column, dispatch]); |
There was a problem hiding this comment.
fixes infinite render loop
There was a problem hiding this comment.
Oh very nice thank you for catching that
dauglyon
commented
May 14, 2024
Comment on lines
-157
to
-162
| const context = result.requestId | ||
| ? requestContext.current[result.requestId] | ||
| : undefined; | ||
| if (!collectionId || !result?.data || !context || result.isError) | ||
| return {}; | ||
| return { filterData: result.data, context }; |
There was a problem hiding this comment.
Removed unnescary hacky context state (requestContext) that was causing issues, prefer just canceling the requests when the context changes (line 317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.