-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample context tabs #193
Sample context tabs #193
Conversation
I'm running into some weird behavior with the Selected tab on the samples page. Sometimes the count in the tab is showing all the samples but the table is showing them filtered to 2-4. It's hard to reproduce consistently but see if you see the issue by following these steps:
You may have to repeat 6-9 a couple times. |
hmmm, thanks. Ill take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great for me now. I like you solution linking to the genomes table with the ids filter applied. It might be a little confusing how you lose your existing filters but that's how I would expect it to work in this case. It connects the samples to the genomes right now so I'd say it's a value add.
One thing I noticed is that all the genome count links get marked with the :visited state after you click on any of them. Maybe we can disable the :visited state on those links for now. |
@codytodonnell lets run it by the team at standup before I merge, but I imagine they'll defer to you |
No description provided.