Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample context tabs #193

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Sample context tabs #193

merged 7 commits into from
Apr 4, 2024

Conversation

dauglyon
Copy link
Collaborator

@dauglyon dauglyon commented Apr 3, 2024

No description provided.

@codytodonnell
Copy link
Collaborator

I'm running into some weird behavior with the Selected tab on the samples page. Sometimes the count in the tab is showing all the samples but the table is showing them filtered to 2-4. It's hard to reproduce consistently but see if you see the issue by following these steps:

  1. Open ENIGMA collection
  2. Go to Genome Attributes
  3. Select 2 genomes
  4. Go to Sample Attributes
  5. Click on Selected tab
  6. Go back to Genome Attributes
  7. Select 2 more genomes
  8. Go to Sample Attributes
  9. Click on Selected tab

You may have to repeat 6-9 a couple times.

@dauglyon
Copy link
Collaborator Author

dauglyon commented Apr 3, 2024

hmmm, thanks. Ill take a look

Copy link
Collaborator

@codytodonnell codytodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great for me now. I like you solution linking to the genomes table with the ids filter applied. It might be a little confusing how you lose your existing filters but that's how I would expect it to work in this case. It connects the samples to the genomes right now so I'd say it's a value add.

@codytodonnell
Copy link
Collaborator

One thing I noticed is that all the genome count links get marked with the :visited state after you click on any of them. Maybe we can disable the :visited state on those links for now.

@dauglyon
Copy link
Collaborator Author

dauglyon commented Apr 3, 2024

@codytodonnell lets run it by the team at standup before I merge, but I imagine they'll defer to you

@dauglyon dauglyon merged commit ddefcad into main Apr 4, 2024
4 checks passed
@dauglyon dauglyon deleted the sample-context-tabs branch April 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants