Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable and debounce classification search bar #189

Merged
merged 1 commit into from
Mar 27, 2024
Merged

enable and debounce classification search bar #189

merged 1 commit into from
Mar 27, 2024

Conversation

dauglyon
Copy link
Collaborator

No description provided.

codytodonnell
codytodonnell approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@codytodonnell codytodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick turnaround! Working well on my end.

The only issue I'm seeing is that the values between the search bar and the classification input in the filters panel can get out of sync but I think we can live with this issue for now.

@dauglyon dauglyon merged commit 3c9ceba into main Mar 27, 2024
4 checks passed
@dauglyon dauglyon deleted the classification-search-bar branch March 27, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codytodonnell codytodonnell codytodonnell approved these changes

@dakotablair dakotablair Awaiting requested review from dakotablair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dauglyon @codytodonnell