-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RE2022-307 Filter Contexts #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95aadbb
to
a979d06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking fantastic. I'm noticing two issues though:
- The species taxa chart seems to be constantly reloading on both the Taxa Chart page and the Overview page
- The matches are cleared out when you exit the collection (i.e. go back to the collections browsing page) but if you return to the collection the matching button still shows "Matching by MinHash Homolgy." I might expect the matches to persist until I specifically click "Clear Match" or until I reload the page
Two other things I just noticed:
|
codytodonnell
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of filter contexts, which are controlled by the "Filter Context Tabs" (All/Matched/Selected). Fixed filter contexts can also be set for dataproducts without matched/selected tabs. FilterContexts are strings of the form
[scope].[mode]
where scope is the "filter source" (eg biolog, genomes, samples), and mode is the view mode for that scope (all/matched/selected). These contexts allow different filters to be applied across different scopes AND across different modes (tabs).This PR includes the state and queries needed to support filtering in all dataproducts, but only implements filtering in the genome_attribs dp. Implementing samples filtering should be a quick PR after this one.