RE2022-241: Microtrait update #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dakotablair
commented
Dec 4, 2023
•
dakotablair
commented
- RE2022-241: HeatMap component refactor
- tooltips
- cursor following tooltip which locks on click
- content selectable for clipboard management
- constrain axis ranges to data
- If a user navigates outside the range of the data, the view should revert to showing the data.
- labels render vertically
- some things we get for free with plotly.js:
- quick rendering of ~30k cells
- zoom, scroll
- labels adjust to available space
- column labels at top
- update width on window resize
- tooltips
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dakotablair
commented
Dec 14, 2023
dakotablair
force-pushed
the
microtrait-update
branch
from
9823177 to
57f86c3
Compare
dakotablair
force-pushed
the
microtrait-update
branch
from
6a1b9b3 to
f8cf7b0
Compare
dakotablair
force-pushed
the
microtrait-update
branch
2 times, most recently
from
45a782d to
a90944b
Compare
dakotablair
force-pushed
the
microtrait-update
branch
4 times, most recently
from
6364e1b to
2213a30
Compare
Closed
dakotablair
force-pushed
the
microtrait-update
branch
2 times, most recently
from
5016a9a to
a0ca48a
Compare
dauglyon
reviewed
Mar 7, 2024
src/features/navigator/NarrativeControl/NarrativeControl.test.tsx
Outdated
Show resolved
Hide resolved
"Use React refs" --David Lyon Also updated getCellLabel in Biolog and Microtrait to be more similar. This function may be good candidate for abstraction. Co-authored-by: David Lyon <[email protected]>
Specifically @floating-ui dependencies and gtag mocks.
dakotablair
force-pushed
the
microtrait-update
branch
from
6d25046 to
fe274c1
Compare
Added Plotly range bug comment.
This commit also updates the other tooltip data to present KBase identifiers for both biolog and microtrait data products.
dauglyon
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.