Updated NMDC metadata to include inlined biosample metadata descriptors. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a distinction between "file" and "data" descriptors. The former category includes descriptors that (ehm) describe files to be moved in transfers, whereas the latter includes in-line data which is placed into the transfer manifest. This lets us include NMDC biosample metadata, which is not stored in files within NMDC. These metadata are stored in a simple JSON format which is transplanted to the manifest as is.
This PR should also go in after the Frictionless overhaul, which is again waiting on a production Spin instance of the DTS. (After all, we wouldn't want all these radical updates to go straight to production!)
NOTE: I need to test this PR with some data objects/studies/biosample metadata that are properly related within NMDC.
NOTE ALSO: There's some duplicate credit schema reformatting code here because too many branches.