Updated JDP metadata to include Organism-level stuff. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-cohere
added
the
JDP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the (undocumented) per-file metadata endpoint the JDP team added for us is perfectly capable of delivering "top-level" (organism) metadata for each of its files if one sets a flag indicating that results should be "aggregated." I've taken the opportunity to merge the code paths for file search and per-file "descriptor" (metadata) retrieval.
This PR should go in after the Frictionless overhaul PR, which is waiting on my deployment of a "production" Spin instance of DTS (which is now at the top of my list!).