feat: bump re2 version to 2024-07-02 #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
changed the title
|
Hardcoded the abseil nix store path as Looks like similar problem as protocolbuffers/protobuf#16314 (comment) |
kachick
changed the title
kachick
commented
Sep 25, 2024
| emscripten # `emcc` | ||
| ]; | ||
| # LD_LIBRARY_PATH = lib.makeLibraryPath [ pkgs.abseil-cpp ]; | ||
| # propagatedBuildInputs = [ pkgs.abseil-cpp pkgs.icu ]; |
There was a problem hiding this comment.
|
They are still using abseil 20240116.2 instead of 20240722.0 https://github.com/google/re2/blob/6dcd83d60f7944926bfd308cc13979fc53dd69ca/MODULE.bazel#L16 If I need to specify version, pick from https://github.com/NixOS/nixpkgs/tree/15ddcc64cdd2587e58d90334a9cfa49de308b7c7/pkgs/development/libraries/abseil-cpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/google/re2/releases/tag/2024-04-01