Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of updates #4

Merged
merged 9 commits into from
Apr 18, 2017
Merged

Bunch of updates #4

merged 9 commits into from
Apr 18, 2017

Conversation

1999
Copy link
Contributor

@1999 1999 commented Apr 17, 2017

  • Remove domain module usage. This module is long time deprecated and it's not recommended for usage (link 1, link 2, link 3). Also if error occurs inside worker it will be disconnected and re-forked.
  • Add 4th option isListening to MC.createHttpServer so that it can be used as a 100% replacement of http.createServer or expressApp.listen (supports all of their API)
  • Document isCluster option
  • Use node.js assert instead of if..throw - this makes the code cleaner
  • Refactoring (counter renamed to counterReloadWorkerFails, noop used instead of empty functions)
  • Misc

Copy link
Owner

@jtblin jtblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the PR! I knew domain was deprecated and wanted to remove it for a while. Unfortunately there's no replacement yet but as you indicated if a worker crashes, it will be restarted anyway.

@jtblin jtblin merged commit 79e6f97 into jtblin:master Apr 18, 2017
@1999 1999 deleted the fixes branch April 18, 2017 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants