Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Added job to detect changes in unauthorized files #696

Merged
merged 2 commits into from
May 27, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented May 19, 2024

What kind of change does this PR introduce?

  • Feature : Added job to detect changes in unauthorized files.

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

  • This job will helps us to prevent changes in unauthorized files which makes review process more easier and faster also help us to prevent malicious changes in pull-request.

Does this PR introduce a breaking change?

@aialok aialok requested a review from a team as a code owner May 19, 2024 19:41
@aialok aialok changed the title Feat : Added job for changes in unauthorized files Feat : Added job to detect changes in unauthorized files May 19, 2024
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aialok where was this discussed? I see the issue, but it's just you proposing it. There's no discussion of whether we should have it.

@benjagm
Copy link
Collaborator

benjagm commented May 20, 2024

@aialok where was this discussed? I see the issue, but it's just you proposing it. There's no discussion of whether we should have it.

The work that Alok is doing is part of GSoC. I don't see a way to progress the project discussing all the tasks with the community. I am checking with him the plan and the backlog.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few suggestions friend Alok : )

@aialok
Copy link
Member Author

aialok commented May 20, 2024

Adding a few suggestions friend Alok : )

Thank you @DhairyaMajmudar : )
Done with requested changes.

@aialok aialok added the GSoC Google Summer of Code related label May 20, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this. Maybe we'll need to remove files like tailwind.config.js in the future.

@benjagm benjagm merged commit d571fa9 into json-schema-org:main May 27, 2024
3 of 4 checks passed
aialok added a commit to aialok/website that referenced this pull request May 27, 2024
…-org#696)

* Added job Check-Unauthorized-files-changes

* Fixes minor bug
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Jun 2, 2024
…-org#696)

* Added job Check-Unauthorized-files-changes

* Fixes minor bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: github-actions - Setup authorised file detection job
4 participants