Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests for Node@8 and Node@9 #317

Closed
carpasse opened this issue Mar 26, 2024 · 0 comments · Fixed by #318
Closed

Broken tests for Node@8 and Node@9 #317

carpasse opened this issue Mar 26, 2024 · 0 comments · Fixed by #318

Comments

@carpasse
Copy link
Contributor

carpasse commented Mar 26, 2024 •
edited
Loading

Seems like the current master branch have some broken tests when running Node@8 and Node@9. @UlisesGascon notice that when running my changes for PR #316

I can not provide a failed build because the workflow is waiting for approval
Screenshot 2024-03-26 at 09 48 29

But I can see the ci-test action failing in my forked repo
https://github.com/carpasse/mime-db/actions/runs/8418349804/job/23048681716

Similar error in both cases: https://github.com/jshttp/mime-types/actions/runs/8278038868/job/22655381584#step:10:15, here is an screenshot in case that you can't access to the logs:
Screenshot 2024-03-26 at 09 49 59
@carpasse carpasse changed the title Broken tests for Node@8 and Node@9 #122 Broken tests for Node@8 and Node@9 Mar 26, 2024
carpasse added a commit to carpasse/mime-db that referenced this issue Mar 26, 2024
@carpasse
ci: pin versions nyc version for testing on old versions of node <= 9
874344f 
Also removed Node.js version 0.6 GH fails to install it.

Closes jshttp#317
Same fix as jshttp/http-errors#109
@carpasse carpasse mentioned this issue Mar 26, 2024
Merged
carpasse added a commit to carpasse/mime-db that referenced this issue Mar 26, 2024
@carpasse
Pin versions nyc version for testing on old versions of node <= 9
e4e295c 
Closes jshttp#317
Same fix as jshttp/http-errors#109
UlisesGascon pushed a commit that referenced this issue Mar 27, 2024
@carpasse
chore: pin versions nyc version for testing on old versions of node <= 9
850ad28 
PR: #318 
REF: #317 and https://github.com/jshttp/http-errors#109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pin versions nyc version for testing on old versions of node <= 9 carpasse/mime-db
1 participant
@carpasse