Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS inconsistency (parse method never returns undefined). #215

Closed
wants to merge 1 commit into from
Closed

Fix TS inconsistency (parse method never returns undefined). #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export interface ParseOptions {
*
* @default decode
*/
decode?: (str: string) => string | undefined;
decode?: (str: string) => string;
}

/**
Expand All @@ -98,8 +98,8 @@ export interface ParseOptions {
export function parse(
str: string,
options?: ParseOptions,
): Record<string, string | undefined> {
const obj: Record<string, string | undefined> = new NullObject();
): Record<string, string> {
const obj: Record<string, string> = new NullObject();
const len = str.length;
// RFC 6265 sec 4.1.1, RFC 2616 2.2 defines a cookie name consists of one char minimum, plus '='.
if (len < 2) return obj;
Expand Down