-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip demodulation #778
Comments
Thank you very much, I am glad URH is so useful for you! What do you exactly mean by "the source signal is already demodulated"? Do you have the bits already or you have a rectangular signal?
|
Yeah the demodulated signal does not look so good after all. There are many interruptions. Maybe a moving average filter might help here? Apart from that, I see that you are loading a wav file which is not the best format to work with. |
Well, the moving average filter changes things, but does not make that much better. Sure, wav files are not preferred by URH but I guessed it worked because the analog display of the signal was correct (cross checked with baudline). |
Maybe ASK does not work because there are no complex numbers in the file. It's just a wav. 16 bit floats, single channel. So you can't do a complex to magnitude transformation (which is typically done for ASK). |
Ah it is single channel, that explains a lot! Yes you are right, in that case the ASK demodulation will make you lose the sign of the amplitude so you cannot distinguish between 1 and 0 anymore. |
But since most (all?) demodulated signals are single channel a "Skip" option might add value to URH. |
Yes I totally agree with you. In fact, I can't think of a useful way to use a single channel wav with URH except from interpreting it as already demodulated data as URH's demodulation routines require IQ data. I implemented this in the |
Damn, how are you always this fast with implementing stuff? ;) I've tried to build the branch but I got an build error.
|
A clean codebase always pays off. ;) Ah yeah, there was a bug introduced in Cython a while ago. Does it help when you run |
I was using cython 0.29.19. Downgrading to 0.29.17 worked. I also had an issue with And the result was great! It works perfectly with the wav! One question: do I need to use a wav? Or can I use a raw file as well and select something like "Skip" or "Single Channel"? |
Yes, you need to use wav as it is the only way to determine whether the data is one or two channel. I am hesistant to add a general "Skip" functionality to URH as it may confuse users (it is already quite packed with features and options). I think having a raw demodulated file is rare in practice anyway and you could always convert such a file to a single channel wav, if neccessary. I am glad to hear this branch solves your problem! I will merge the branch into master now. |
Hi,
I've used this great tool to solve a challenge from the https://www.hackasat.com/ CTF. Once again: Thank you so much for this tool! By solving the challenge I noticed a interesting use case.
URH has it all! Demodulation, clock recovery, line encodings, etc. However, what if the source signal is already demodulated? I was not able to find a way to skip demodulation. I really would like the dropdown menue with ASK, FSK and PSK to have another option: "Skip". This would allow me to still use all the awesome features for signal analysis and generation on a already demodulated signal.
The text was updated successfully, but these errors were encountered: