Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom date-time, date, time classes. #469

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

joelittlejohn
Copy link
Owner

Tidying up and replacing #433.

Allow to specify jsr310 classes i.e. java.time.* (jdk 8) but mantain
compatibility at compile level 1.6.
@joelittlejohn
Copy link
Owner Author

@dmiorandi I've recreated this by exporting a patch from your fork. Could you take a look through the changes and let me know if you're happy for me to merge this:

https://github.com/joelittlejohn/jsonschema2pojo/pull/469/files

?

Thanks

@dmiorandi
Copy link
Contributor

Your commit seems ok. Please go on.
Tks @joelittlejohn for you support.

A question, more or less when you have in plan to release x.18?

@joelittlejohn
Copy link
Owner Author

Oh, very soon if you need it. I'm happy to do a release with just one
change if necessary.
On 18 Dec 2015 5:37 p.m., "Denis Miorandi" [email protected] wrote:

Your commit seems ok. Please go on.
Tks @joelittlejohn https://github.com/joelittlejohn for you support.

A question, more or less when you have in plan to release x.18?


Reply to this email directly or view it on GitHub
#469 (comment)
.

joelittlejohn added a commit that referenced this pull request Dec 18, 2015
Added support for custom date-time, date, time classes.
@joelittlejohn joelittlejohn merged commit 508f07e into master Dec 18, 2015
@dmiorandi
Copy link
Contributor

Ok I would like integrate .18 into raml-for-jax-rs that in under releasing in these days,
so I'm going to try merged snapshot and if it's all right I would like to ask to you a release.

@dmiorandi
Copy link
Contributor

Ok merged snapshot is ok for me. I've made a manual test rebuilding my project with .18-SNAPSHOT
and works as expected.
If is possible to have a release .18 with just this feature should be great!
Tks @joelittlejohn for your availability.

@joelittlejohn joelittlejohn added this to the 0.4.18 milestone Dec 18, 2015
@joelittlejohn
Copy link
Owner Author

@dmiorandi 0.4.18 has been released, it will appear in Maven Central in a few hours.

@dmiorandi
Copy link
Contributor

Great news. Tks

@thachhoang thachhoang deleted the custom-date-time branch August 21, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants