Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter AppStore subscriptions by product ids #38

Closed
wants to merge 1 commit into from
Closed

Filter AppStore subscriptions by product ids #38

wants to merge 1 commit into from
+91 −41

Conversation

sonxurxo
Copy link

No description provided.

@sonxurxo sonxurxo mentioned this pull request Jul 17, 2019
Closed
@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 99.927% when pulling 3c6c4b5 on sonxurxo:feature/app_store_multiproduct into 28872f9 on jnbt:master.

@sonxurxo sonxurxo force-pushed the feature/app_store_multiproduct branch from 9e35d5c to 3c6c4b5 Compare July 17, 2019 15:57
@sonxurxo
Copy link
Author

Just force-pushed because I removed the bundle version update in .travis.yml and gemspec

@jnbt jnbt changed the title Fixes https://github.com/jnbt/candy_check/issues/36 Filter AppStore subscriptions by product ids Aug 2, 2019
@jnbt jnbt mentioned this pull request Aug 2, 2019
Merged
@jnbt
Copy link
Owner

jnbt commented Aug 2, 2019

@sonxurxo I moved your changed to an own PR #40, because I didn't wanted the Verification or RecipeCollection class to be changed for a specific use case.
Instead I moved most of the modifications to SubscriptionVerification

@jnbt jnbt closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sonxurxo @coveralls @jnbt