Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fixes (fixed #2, fixed #3) #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

afrixs
Copy link

@afrixs afrixs commented Nov 20, 2019

I investigated the code a bit and found reasons of some reported issues, fixed the problems and tested on all provided polygons.
Problematic was (in most cases) duplication of a point when connecting a hole to the outer polygon. The duplicated point wasn't handled properly afterwards.
Example

             Hole
          ---------
          |       |
          |  A B  |
          ---+ +---
  Connection | | 
             | |           C
-------------+ +----------+-------
                   Outer polygon

A and B are a duplicated point (they have the same coordinates)
Cut line was sometimes mistakenly drawn from C to A (should be C to B) or from A to B.

Also fixed a mistakenly written line in acd2d_data.cpp in foundBoundary which caused errors.

Also added coloring of final polygons and a display option of showing point coordinates for a better visualisation and further potential debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant