Pulling upstream changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to pull down butler were failing, since there's no arm64 channel available. Instead, we force all macs to fetch the amd64 channel.
This resolves two bugs: 1. Links with `target="_blank"` not opening when left-clicked 2. Non-itch urls opening in the app browser (rather than external browser) when ctrl-clicked The second was occurring because the wrong `loadURL` function was being called, and we were bypassing our itch.io domain restriction. The first was due to us not opting in to allowing popups, which appears to have become required in Electron 22 (not confirmed, but that was the version where window handling logic most significantly changed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.