Properly linked insertBefore with fragments.
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `insertBefore` to accept a `DocumentFragment`. Apparently, that branch of logic was not tested. It called the non-existent `Node.firstNode` instead of `Node.firstChild`. Updated `appendChild` and `insertBefore` to return the inserted `Node` according to the WC3 DOM Level 2. Set the `nodeType` property of `DocumentFragment` objects.
|
Fixing a spelling error in the commit message. Going to force update. Okay; done. |
|
Well done |
ghost
assigned
jindw
added a commit
that referenced
this pull request
Jun 11, 2012
Properly linked `insertBefore` with fragments.
emmkimme
pushed a commit
to emmkimme/xmldom
that referenced
this pull request
Jul 8, 2020
* Various maintenance - More package.json refactoring. - Removed .npmignore in favor of `files` entry in package.json. - Renamed dom-parser.js to domParser.js. - Replaced CHANGELOG with more rigorous file. - Replaced LICENSE with more rigorous file. - Removed component.json (deprecated package manager https://github.com/componentjs/guide) - `proof` devDep updated to latest. Closes jindw#2. Closes jindw#12. Closes jindw#20. Requesting review from @brodybits @timbru31. Pending approval and merge, we should release this as 0.2.2. * CHANGELOG tweak * Bump minor instead of patch * Bump minor instead of patch * fix tests? * fix tests * rename... * fix tests * fix package lock * update CHANGELOG and tilda proof. * rename back * update CHANGELOG * consistency * moving files to lib * Update lib/dom-parser.js Co-Authored-By: Chris Brody <[email protected]> * Update CHANGELOG.md Co-Authored-By: Chris Brody <[email protected]> * past tense Co-authored-by: Chris Brody <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
insertBeforeto accept aDocumentFragment. Apparently, that branch of logic was not tested. It called the non-existantNode.firstNodeinstead ofNode.firstChild.Updated
appendChildandinsertBeforeto return the insertedNodeaccording to the WC3 DOM Level 2.Set the
nodeTypeproperty ofDocumentFragmentobjects.Created an example of what to expect when you insert a
DocumentFragment.