Add rank when building modules #12075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanfranca
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Thank you for your work @pascalgrimaud ! I liked the solution to automated the configuration!
murdos
reviewed
Mar 10, 2025
| @@ -26,7 +26,7 @@ private JHipsterModuleResource(JHipsterModuleResourceBuilder builder) { | |||
| apiDoc = builder.apiDoc; | |||
| tags = builder.tags; | |||
| organization = builder.organization; | |||
| rank = Optional.ofNullable(builder.rank).orElse(JHipsterModuleRank.RANK_D); | |||
| rank = JHLiteModuleSlug.getRank(slug.get()).orElse(JHipsterModuleRank.RANK_D); | |||
There was a problem hiding this comment.
The issue is that this will not work for slugs of custom modules from a custom jhlite.
A proper solution is to extends the module slug factory interface.
There was a problem hiding this comment.
Indeed, all custom modules will be rank D :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.