Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and run from Docker Support #5

Closed

Conversation

Rajpratik71
Copy link

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because
of a no. of different jhipster blueprints are there,
which are compatible and works with the different version of jhipster
and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj [email protected]

@Rajpratik71 Rajpratik71 force-pushed the feat/docker-support branch 2 times, most recently from d9a3197 to ee5db7b Compare October 6, 2020 06:11
@mshima mshima changed the base branch from master to main October 19, 2020 14:52
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the use case for this.

I started using docker recently but if you want to test the blueprint against different version of generator-jhipster, probably is better to use generator-jhipster docker with custom command and rely on generator-jhipster blueprint auto install.

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because
of a no. of different jhipster blueprints are there,
which are compatible and works with the different version of jhipster
and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj <[email protected]>
@mshima
Copy link
Member

mshima commented Oct 24, 2020

This PR was closed due to a force-push on main branch.
It had 2 root commits and was giving problems to some tools.

  • Extract docker howto into a new file, I prefer to keep README.md clean, I still no convinced the docker will be helpful.
  • Change master branch references to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants