refactor!: Rename IEventCodec.TryDecode to Decode #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this reduces confusion as `TryDecode` can actually throw an exception and the `voption` return value is to indicate that the event, while valid (probably at some other time in the past), should be ignored
bartelink
reviewed
Nov 16, 2023
Co-authored-by: Ruben Bartelink <[email protected]>
bartelink
reviewed
Nov 16, 2023
bartelink
reviewed
Nov 16, 2023
Co-authored-by: Ruben Bartelink <[email protected]>
Co-authored-by: Ruben Bartelink <[email protected]>
bartelink
reviewed
Nov 16, 2023
bartelink
reviewed
Nov 16, 2023
bartelink
reviewed
Nov 16, 2023
bartelink
changed the title
Co-authored-by: Ruben Bartelink <[email protected]>
|
Thanks! The small changes (that takes ages!) are every bit as imporant... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reduces confusion as
TryDecodecan actually throw an exceptionand the
voptionreturn value is to indicate that the event, whilevalid (probably at some other time in the past), should be ignored