Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings: include fstream #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JanMarvin
Copy link
Contributor

@JanMarvin JanMarvin commented Mar 21, 2025

Not sure if something what changed on the V8 side of things, but building with V8 13.6.129 I'm seeing:

==> Rcpp::compileAttributes()

* Updated R/RcppExports.R

==> R CMD INSTALL --preclean --no-multiarch --with-keep.source V8

* installing to library/home/jmg/R/x86_64-pc-linux-gnu-library/4.4/_build* installing *source* packageV8...
** using staged installation
Found C++20 compiler: g++
Using CXXCPP=g++ -std=gnu++20 -E
Using PKG_CFLAGS=-I/usr/include/v8
Using PKG_LIBS=-lv8 -lv8_libplatform
Running feature test for pointer compression...
Enabling pointer compression
Running feature test for sandbox...
Enabling sandbox
** libs
rm -f V8.so RcppExports.o bindings.o
g++ -std=gnu++20 -I"/usr/include/R/" -DNDEBUG -I/usr/include/v8 -DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX -I'/home/jmg/R/x86_64-pc-linux-gnu-library/4.4/Rcpp/include' -I/usr/local/include   -fvisibility=hidden -fpic  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/r/src=/usr/src/debug/r -flto=auto -ffat-lto-objects   -c RcppExports.cpp -o RcppExports.o
using C++ compiler:g++ (GCC) 14.2.1 20250207using C++20
g++ -std=gnu++20 -I"/usr/include/R/" -DNDEBUG -I/usr/include/v8 -DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX -I'/home/jmg/R/x86_64-pc-linux-gnu-library/4.4/Rcpp/include' -I/usr/local/include   -fvisibility=hidden -fpic  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/r/src=/usr/src/debug/r -flto=auto -ffat-lto-objects   -c bindings.cpp -o bindings.o
bindings.cpp: In functionstd::string read_text(std::string)’:
bindings.cpp:59:27: error: variablestd::ifstream thas initializer but incomplete type
   59 |   std::ifstream t(filename);
      |                           ^
bindings.cpp:3:1: note:std::ifstreamis defined in header<fstream>’; this is probably fixable by adding#include <fstream>’
    2 | #include "V8_types.h"
  +++ |+#include <fstream>
    3 | 
make: *** [/usr/lib64/R/etc/Makeconf:204: bindings.o] Error 1
ERROR: compilation failed for packageV8* removing/home/jmg/R/x86_64-pc-linux-gnu-library/4.4/_build/V8Exited with status 1.

@JanMarvin
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant