This repository was archived by the owner on Jan 16, 2019. It is now read-only.
Pass the UndoToken to onHide as well #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his is useful for doing stuff that is not actually undoable and should only be executed after the user had his chance to undo
… up in safelyNotifyOnUndo. Although it's super unlikely that this actually happens I think it's cleaner to first grab a reference
|
love |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass the token to the listener onHide as well (not just in onUndo). this is useful for doing stuff that is not actually undoable and should only be executed after the user had his chance to undo.
Also included a little fix to avoid a (very very unlikely) race condition.