Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #81 #84

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Fix #81 #84

merged 2 commits into from
Jun 22, 2021

Conversation

PangMo5
Copy link
Member

@PangMo5 PangMo5 commented Jun 22, 2021 •
edited
Loading

Changed

  • Replaced Spacer.frame with .padding in HomeView
  • ConnectToServerViewModel tracked ActivityIndicator
  • Replaced @StateObject with @ObservedObject in LatestMediaView(RowView)
  • Remove Unnecessary Code

@PangMo5
fix jellyfin#81
23ecc54 
ConnectToServerViewModel tracked ActivityIndicator
Remove Unnecessary Code
@PangMo5 PangMo5 requested a review from acvigue as a code owner June 22, 2021 03:08
acvigue
acvigue approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@acvigue acvigue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acvigue acvigue merged commit 0786988 into jellyfin:main Jun 22, 2021
@PangMo5 PangMo5 deleted the PangMo5/#81-fix branch July 23, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acvigue acvigue acvigue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PangMo5 @acvigue